Merge pull request #3085 from yongthecoder/regfree

Do not call regfree() on an empty regex that is not successfully created...
This commit is contained in:
Carlos Martín Nieto 2015-04-29 22:08:46 +02:00
commit 891cc5045f

View File

@ -343,7 +343,6 @@ typedef struct {
git_config_iterator *current;
const git_config *cfg;
regex_t regex;
int has_regex;
size_t i;
} all_iter;
@ -480,7 +479,6 @@ int git_config_iterator_glob_new(git_config_iterator **out, const git_config *cf
if ((result = regcomp(&iter->regex, regexp, REG_EXTENDED)) != 0) {
giterr_set_regex(&iter->regex, result);
regfree(&iter->regex);
git__free(iter);
return -1;
}
@ -983,6 +981,7 @@ void multivar_iter_free(git_config_iterator *_iter)
iter->iter->free(iter->iter);
git__free(iter->name);
if (iter->have_regex)
regfree(&iter->regex);
git__free(iter);
}