proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-07 12:57:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix sparse warnings: "symbol not declared. Should it be static?"

Browse Source 
In particular, sparse issues the following warnings:

    src/revobject.c:29:14: warning: symbol 'max_load_factor' was \
        not declared. Should it be static?
    src/revobject.c:31:14: warning: symbol 'git_revpool_table__hash' was \
        not declared. Should it be static?

In order to suppress these warnings, we simply declare them as
static, since they are not (currently) referenced outside of this
file.

In the case of max_load_factor, this is probably correct. However,
this may not be appropriate for git_revpool_table__hash(), given
how it is named. So, this should either be re-named to reflect it's
non-external status, or a declaration needs to be added to the
revobject.h header file.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Andreas Ericsson <ae@op5.se>
This commit is contained in:
Ramsay Jones 2010-06-01 19:33:57 +01:00 committed by Andreas Ericsson
parent ee1765e529
commit 84b9cec72c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/revobject.c
View File

@ -26,9 +26,9 @@
#include "common.h"
#include "revobject.h"
const double max_load_factor = 0.65;
static const double max_load_factor = 0.65;
unsigned int git_revpool_table__hash(const git_oid *id)
static unsigned int git_revpool_table__hash(const git_oid *id)
{
return *((unsigned int *)id->id);
}