From 7be5104d241ce84537076ad92d2ac1604ea33b8a Mon Sep 17 00:00:00 2001 From: Ben Straub Date: Thu, 31 Oct 2013 13:15:49 -0700 Subject: [PATCH] Add tests for badly-formed URLs --- tests-clar/clone/nonetwork.c | 8 ++------ tests-clar/network/urlparse.c | 7 +++++++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/tests-clar/clone/nonetwork.c b/tests-clar/clone/nonetwork.c index 9eb4bf9db..90e1e6439 100644 --- a/tests-clar/clone/nonetwork.c +++ b/tests-clar/clone/nonetwork.c @@ -56,13 +56,9 @@ void test_clone_nonetwork__bad_urls(void) cl_assert(!git_path_exists("./foo")); cl_git_fail(git_clone(&g_repo, "git://example.com:asdf", "./foo", &g_options)); - cl_assert(!git_path_exists("./foo")); - cl_git_fail(git_clone(&g_repo, "git://example.com:asdf/foo", "./foo", &g_options)); - cl_assert(!git_path_exists("./foo")); - cl_git_fail(git_clone(&g_repo, "https://example.com:asdf", "./foo", &g_options)); - cl_assert(!git_path_exists("./foo")); cl_git_fail(git_clone(&g_repo, "https://example.com:asdf/foo", "./foo", &g_options)); - cl_assert(!git_path_exists("./foo")); + cl_git_fail(git_clone(&g_repo, "git://github.com/git://github.com/foo/bar.git.git", + "./bar", &g_options)); } void test_clone_nonetwork__do_not_clean_existing_directory(void) diff --git a/tests-clar/network/urlparse.c b/tests-clar/network/urlparse.c index 274d7e900..15e841b35 100644 --- a/tests-clar/network/urlparse.c +++ b/tests-clar/network/urlparse.c @@ -31,6 +31,13 @@ void test_network_urlparse__trivial(void) cl_assert_equal_p(pass, NULL); } +void test_network_urlparse__bad_url(void) +{ + cl_git_fail_with(gitno_extract_url_parts(&host, &port, &user, &pass, + "github.com/git://github.com/foo/bar.git.git", "443"), + GIT_EINVALIDSPEC); +} + void test_network_urlparse__user(void) { cl_git_pass(gitno_extract_url_parts(&host, &port, &user, &pass,