proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-29 20:42:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

checkout: set ignorecase=0 when config lookup fails

Browse Source 
When `git_repository__cvar` fails we may end up with a
`ignorecase` value of `-1`. As we subsequently check if
`ignorecase` is non-zero, we may end up reporting that data
should be removed when in fact it should not.

Err on the safer side and set `ignorecase = 0` when
`git_repository__cvar` fails.
This commit is contained in:
Patrick Steinhardt 2016-05-02 15:47:54 +02:00
parent fcd1b78601
commit 7b24c4fd48
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/checkout.c
View File

@ -1360,9 +1360,11 @@ fail:
static bool should_remove_existing(checkout_data *data) static bool should_remove_existing(checkout_data *data)
{ {
int ignorecase = 0; int ignorecase;
git_repository__cvar(&ignorecase, data->repo, GIT_CVAR_IGNORECASE); if (git_repository__cvar(&ignorecase, data->repo, GIT_CVAR_IGNORECASE) < 0) {
ignorecase = 0;
}
return (ignorecase && return (ignorecase &&
(data->strategy & GIT_CHECKOUT_DONT_REMOVE_EXISTING) == 0); (data->strategy & GIT_CHECKOUT_DONT_REMOVE_EXISTING) == 0);