From 79e9c3eca29e31dff873a99e33c452c8d5d5b6ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Wed, 10 Aug 2011 18:35:37 +0200 Subject: [PATCH] Update transport lifetime documentation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The original was written before any code was written and had nothing to do with the way things are actually done. Signed-off-by: Carlos Martín Nieto --- src/transport.h | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/transport.h b/src/transport.h index e809734a7..b14684bcb 100644 --- a/src/transport.h +++ b/src/transport.h @@ -26,11 +26,16 @@ typedef struct git_transport_caps { * making use of the direction if necessary. This function must also * store the remote heads and any other information it needs. * - * If we just want to execute ls-remote, ->ls() gets - * called. Otherwise, the have/want/need list needs to be built via - * ->wanthaveneed(). We can then ->push() or ->pull(). When we're - * done, we call ->close() to close the connection. ->free() takes - * care of freeing all the resources. + * The next useful step is to call ->ls() to get the list of + * references available to the remote. These references may have been + * collected on connect, or we may build them now. For ls-remote, + * nothing else is needed other than closing the connection. + * Otherwise, the higher leves decide which objects we want to + * have. ->send_have() is used to tell the other end what we have. If + * we do need to download a pack, ->download_pack() is called. + * + * When we're done, we call ->close() to close the + * connection. ->free() takes care of freeing all the resources. */ struct git_transport { @@ -51,14 +56,6 @@ struct git_transport { * Give a list of references, useful for ls-remote */ int (*ls)(struct git_transport *transport, git_headarray *headarray); - /** - * Calculate want/have/need. May not even be needed. - */ - int (*wanthaveneed)(struct git_transport *transport, void *something); - /** - * Build the pack - */ - int (*build_pack)(struct git_transport *transport); /** * Push the changes over */