proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2026-01-08 17:41:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2659 from swisspol/static_analysis

Browse Source 
Fixed the most obvious Clang static analyzer warnings
This commit is contained in:
Edward Thomson 2014-10-27 12:19:42 -07:00
commit 7647f4495d
5 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/describe.c
View File

@ -571,8 +571,6 @@ static int describe(
}
}
best = (struct possible_tag *)git_vector_get(&all_matches, 0);
git_vector_sort(&all_matches);
best = (struct possible_tag *)git_vector_get(&all_matches, 0);
@ -727,7 +725,7 @@ int git_describe_workdir(
git_oid current_id;
git_status_list *status = NULL;
git_status_options status_opts = GIT_STATUS_OPTIONS_INIT;
git_describe_result *result;
git_describe_result *result = NULL;
git_object *commit;
if ((error = git_reference_name_to_id(&current_id, repo, GIT_HEAD_FILE)) < 0)

2
src/diff_tform.c
View File

@ -949,8 +949,6 @@ find_best_matches:
* Rewrite the diffs with renames / copies
*/
tried_tgts = 0;
git_vector_foreach(&diff->deltas, t, tgt) {
/* skip things that are not rename targets */
if ((tgt->flags & GIT_DIFF_FLAG__IS_RENAME_TARGET) == 0)

2
src/oid.c
View File

@ -211,7 +211,7 @@ int git_oid_ncmp(const git_oid *oid_a, const git_oid *oid_b, size_t len)
int git_oid_strcmp(const git_oid *oid_a, const char *str)
{
const unsigned char *a = oid_a->id;
const unsigned char *a;
unsigned char strval;
int hexval;

1
src/pack.c
View File

@ -1105,7 +1105,6 @@ int git_packfile_alloc(struct git_pack_file **pack_out, const char *path)
p->pack_keep = 1;
memcpy(p->pack_name + root_len, ".pack", sizeof(".pack"));
path_len = path_len - strlen(".idx") + strlen(".pack");
}
if (p_stat(p->pack_name, &st) < 0 || !S_ISREG(st.st_mode)) {

2
src/remote.c
View File

@ -1691,7 +1691,7 @@ int git_remote_rename(git_strarray *out, git_repository *repo, const char *name,
{
int error;
git_vector problem_refspecs = GIT_VECTOR_INIT;
git_remote *remote;
git_remote *remote = NULL;
assert(out && repo && name && new_name);