From 69789922984d2e22f267da5f35cd64cd17c36dc0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Sat, 7 Sep 2013 18:50:35 +0200 Subject: [PATCH] config: return an error when reaching the maximum include depth --- src/config_file.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/config_file.c b/src/config_file.c index 48a91eb4e..034d1d7b1 100644 --- a/src/config_file.c +++ b/src/config_file.c @@ -949,9 +949,10 @@ static int config_parse(diskfile_backend *cfg_file, struct reader *reader, git_c int result = 0; khiter_t pos; - /* FIXME: should we return an error? */ - if (depth >= MAX_INCLUDE_DEPTH) - return 0; + if (depth >= MAX_INCLUDE_DEPTH) { + giterr_set(GITERR_CONFIG, "Maximum config include depth reached"); + return -1; + } /* Initialize the reading position */ reader->read_ptr = reader->buffer.ptr;