proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-06-23 09:10:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pack: fix looping over cache entries

Browse Source 
Fixes a regression from #4092. This is a crash on 32-bit and I assume that
it doesn't do the right thing on 64-bit either. MSVC emits a warning for this,
but of course, it's easy to get lost among all of the similar 'possible loss
of data' warnings.
This commit is contained in:
Jason Haslam 2017-02-22 09:29:00 -07:00
parent b13f0da153
commit 685f22519c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/pack.c
View File

@ -128,13 +128,13 @@ static git_pack_cache_entry *cache_get(git_pack_cache *cache, git_off_t offset)
/* Run with the cache lock held */ /* Run with the cache lock held */
static void free_lowest_entry(git_pack_cache *cache) static void free_lowest_entry(git_pack_cache *cache)
{ {
git_off_t offset;
git_pack_cache_entry *entry; git_pack_cache_entry *entry;
khiter_t k;
git_offmap_foreach(cache->entries, k, entry, { git_offmap_foreach(cache->entries, offset, entry, {
if (entry && entry->refcount.val == 0) { if (entry && entry->refcount.val == 0) {
cache->memory_used -= entry->raw.len; cache->memory_used -= entry->raw.len;
git_offmap_delete_at(cache->entries, k); git_offmap_delete(cache->entries, offset);
free_cache_object(entry); free_cache_object(entry);
} }
}); });