proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-21 14:39:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

use giterr_set_str() wherever possible

Browse Source 
`giterr_set()` is used when it is required to format a string, and since
we don't really require it for this case, it is better to stick to
`giterr_set_str()`.

This also suppresses a warning(-Wformat-security) raised by the compiler.

Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
This commit is contained in:
Pranit Bauva 2016-11-17 01:08:49 +05:30
parent a6763ff93a
commit 65b78ea301
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/index.c
View File

@ -552,7 +552,7 @@ int git_index_clear(git_index *index)
static int create_index_error(int error, const char *msg) static int create_index_error(int error, const char *msg)
{ {
giterr_set(GITERR_INDEX, msg); giterr_set_str(GITERR_INDEX, msg);
return error; return error;
} }

2
src/zstream.c
View File

@ -21,7 +21,7 @@ static int zstream_seterr(git_zstream *zs)
if (zs->zerr == Z_MEM_ERROR) if (zs->zerr == Z_MEM_ERROR)
giterr_set_oom(); giterr_set_oom();
else if (zs->z.msg) else if (zs->z.msg)
giterr_set(GITERR_ZLIB, zs->z.msg); giterr_set_str(GITERR_ZLIB, zs->z.msg);
else else
giterr_set(GITERR_ZLIB, "Unknown compression error"); giterr_set(GITERR_ZLIB, "Unknown compression error");