From 5f3276c7e66fe54b0485da2def84a6ae322cce59 Mon Sep 17 00:00:00 2001 From: Christopher Bargren Date: Tue, 7 Feb 2017 16:33:28 -0700 Subject: [PATCH] Add support for lowercase proxy environment variables curl supports HTTPS_PROXY in addition to https_proxy (and their http counterparts). This change ensures parity with curl's behavior. --- src/remote.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/remote.c b/src/remote.c index 8da7346fb..1f5c58bd2 100644 --- a/src/remote.c +++ b/src/remote.c @@ -773,6 +773,18 @@ int git_remote__get_http_proxy(git_remote *remote, bool use_ssl, char **proxy_ur /* HTTP_PROXY / HTTPS_PROXY environment variables */ error = git__getenv(&val, use_ssl ? "HTTPS_PROXY" : "HTTP_PROXY"); + if (error < 0) { + if (error != GIT_ENOTFOUND) { + return error; + } + + giterr_clear(); + error = 0; + } + + /* try lowercase environment variables */ + error = git__getenv(&val, use_ssl ? "https_proxy" : "http_proxy"); + if (error < 0) { if (error == GIT_ENOTFOUND) { giterr_clear();