proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-12-30 19:51:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

config_file.c: fix memory leaks

Browse Source 
Signed-off-by: schu <schu-github@schulog.org>
This commit is contained in:
schu 2011-08-17 14:05:41 +02:00
parent b6817692a6
commit 5a0659fe3b
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/config_file.c
View File

@ -212,8 +212,10 @@ static int cvar_normalize_name(cvar_t *var, char **output)
/* If there aren't any spaces in the section, it's easy */
if (section_sp == NULL) {
ret = snprintf(name, len + 1, "%s.%s", var->section, var->name);
if (ret < 0)
if (ret < 0) {
free(name);
return git__throw(GIT_EOSERR, "Failed to normalize name. OS err: %s", strerror(errno));
}
*output = name;
return GIT_SUCCESS;
@ -701,12 +703,16 @@ static int parse_section_header(diskfile_backend *cfg, char **section_out)
/* find the end of the variable's name */
name_end = strchr(line, ']');
if (name_end == NULL)
if (name_end == NULL) {
free(line);
return git__throw(GIT_EOBJCORRUPTED, "Failed to parse header. Can't find header name end");
}
name = (char *)git__malloc((size_t)(name_end - line) + 1);
if (name == NULL)
if (name == NULL) {
free(line);
return GIT_ENOMEM;
}
name_length = 0;
pos = 0;
@ -738,8 +744,10 @@ static int parse_section_header(diskfile_backend *cfg, char **section_out)
} while ((c = line[pos++]) != ']');
if (line[pos - 1] != ']')
return git__throw(GIT_EOBJCORRUPTED, "Failed to parse header. Config file ended unexpectedly");
if (line[pos - 1] != ']') {
error = git__throw(GIT_EOBJCORRUPTED, "Failed to parse header. Config file ended unexpectedly");
goto error;
}
name[name_length] = 0;
free(line);
@ -957,7 +965,8 @@ static int config_write(diskfile_backend *cfg, cvar_t *var)
* default case will take care of updating them.
*/
pre_end = post_start = cfg->reader.read_ptr;
free(current_section);
if (current_section)
free(current_section);
error = parse_section_header(cfg, &current_section);
if (error < GIT_SUCCESS)
break;