From 55c5f756d80cb762fa21054c7460359424428668 Mon Sep 17 00:00:00 2001 From: Jeff Hostetler Date: Fri, 17 Apr 2015 09:30:22 -0400 Subject: [PATCH] Attempt to fix Windows TLS memory leak. --- src/global.c | 18 +++++++++++++----- src/global.h | 2 ++ src/win32/pthread.c | 2 ++ 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/global.c b/src/global.c index 1f3432d09..3c97e62e6 100644 --- a/src/global.c +++ b/src/global.c @@ -270,13 +270,21 @@ git_global_st *git__global_state(void) return ptr; } +void git__free_thread_global_state(void) +{ + void *ptr = TlsGetValue(_tls_index); + if (!ptr) + return; + + git__global_state_cleanup(ptr); + git__free(ptr); + TlsSetValue(_tls_index, NULL); +} + BOOL WINAPI DllMain(HINSTANCE dll, DWORD reason, LPVOID reserved) { - if (reason == DLL_THREAD_DETACH) { - void *ptr = TlsGetValue(_tls_index); - git__global_state_cleanup(ptr); - git__free(ptr); - } + if (reason == DLL_THREAD_DETACH) + git__free_thread_global_state(); return TRUE; } diff --git a/src/global.h b/src/global.h index a89a8d6ab..9d763b0c2 100644 --- a/src/global.h +++ b/src/global.h @@ -32,4 +32,6 @@ typedef void (*git_global_shutdown_fn)(void); extern void git__on_shutdown(git_global_shutdown_fn callback); +extern void git__free_thread_global_state(void); + #endif diff --git a/src/win32/pthread.c b/src/win32/pthread.c index ec45ecbe5..a6465d47f 100644 --- a/src/win32/pthread.c +++ b/src/win32/pthread.c @@ -20,6 +20,8 @@ static DWORD WINAPI git_win32__threadproc(LPVOID lpParameter) thread->result = thread->proc(thread->param); + git__free_thread_global_state(); + return CLEAN_THREAD_EXIT; }