proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-29 20:42:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make sure the ref iterator works in an repo without physical presence

Browse Source
This commit is contained in:
Carlos Martín Nieto 2013-05-04 15:16:55 +02:00
parent 69a3c766b6
commit 51fc5e895d
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/refdb.c
View File

@ -128,7 +128,11 @@ int git_refdb_iterator(git_reference_iterator **out, git_refdb *db)
{ {
git_reference_iterator *iter; git_reference_iterator *iter;
/* FIXME: don't segfault when there is no backends */ if (!db->backend || !db->backend->iterator) {
giterr_set(GITERR_REFERENCE, "This backend doesn't support iterators");
return -1;
}
if (db->backend->iterator(&iter, db->backend) < 0) { if (db->backend->iterator(&iter, db->backend) < 0) {
git__free(iter); git__free(iter);
return -1; return -1;

18
tests-clar/refs/iterator.c
View File

@ -74,3 +74,21 @@ void test_refs_iterator__list(void)
} }
git_vector_free(&output); git_vector_free(&output);
} }
void test_refs_iterator__empty(void)
{
git_reference_iterator *iter;
git_odb *odb;
const char *name;
git_repository *empty;
cl_git_pass(git_odb_new(&odb));
cl_git_pass(git_repository_wrap_odb(&empty, odb));
cl_git_pass(git_reference_iterator_new(&iter, empty));
cl_assert_equal_i(GIT_ITEROVER, git_reference_next(&name, iter));
git_reference_iterator_free(iter);
git_odb_free(odb);
git_repository_free(empty);
}