From 50a8fd03673f270a2c1ce5159287efeecfbf1217 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Tue, 16 Aug 2011 18:16:44 +0200 Subject: [PATCH] Fix the reference character check for Unicode MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We need to do an unsigned comparison, as otherwise UTF-8 characters might look like they have the sign bit set and the check will fail. Signed-off-by: Carlos Martín Nieto --- src/refs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/refs.c b/src/refs.c index 2e5466886..ecd53a69a 100644 --- a/src/refs.c +++ b/src/refs.c @@ -1647,7 +1647,7 @@ void git_repository__refcache_free(git_refcache *refs) *****************************************/ static int check_valid_ref_char(char ch) { - if (ch <= ' ') + if ((unsigned) ch <= ' ') return GIT_ERROR; switch (ch) { @@ -1752,4 +1752,4 @@ int git_reference__normalize_name(char *buffer_out, size_t out_size, const char int git_reference__normalize_name_oid(char *buffer_out, size_t out_size, const char *name) { return normalize_name(buffer_out, out_size, name, 1); -} \ No newline at end of file +}