proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-06-23 03:19:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Indexer: Avoid a possible double-deletion in error case

Browse Source
This commit is contained in:
Sascha Cunz 2012-11-18 09:07:35 +01:00
parent 0066955d97
commit 4cc7342e95
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/indexer.c
View File

@ -249,8 +249,10 @@ static int hash_and_save(git_indexer_stream *idx, git_rawobj *obj, git_off_t ent
git_oid_cpy(&pentry->sha1, &oid); git_oid_cpy(&pentry->sha1, &oid);
pentry->offset = entry_start; pentry->offset = entry_start;
if (git_vector_insert(&idx->pack->cache, pentry) < 0) if (git_vector_insert(&idx->pack->cache, pentry) < 0) {
git__free(pentry);
goto on_error; goto on_error;
}
git_oid_cpy(&entry->oid, &oid); git_oid_cpy(&entry->oid, &oid);
entry->crc = crc32(0L, Z_NULL, 0); entry->crc = crc32(0L, Z_NULL, 0);
@ -275,7 +277,6 @@ static int hash_and_save(git_indexer_stream *idx, git_rawobj *obj, git_off_t ent
on_error: on_error:
git__free(entry); git__free(entry);
git__free(pentry);
git__free(obj->data); git__free(obj->data);
return -1; return -1;
} }