proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-08-13 21:29:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

git_futils: don't O_EXCL and O_TRUNC

Browse Source 
`O_EXCL` and `O_TRUNC` are mutually exclusive flags to open(2); you can't
truncate a file if you're asserting that it can't exist in the first place.
Drop `O_TRUNC`.
This commit is contained in:
Edward Thomson 2017-03-22 19:48:50 +00:00
parent 33ea4aae37
commit 4a26915d34
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/fileops.c
View File

@ -66,8 +66,8 @@ int git_futils_creat_withpath(const char *path, const mode_t dirmode, const mode
int git_futils_creat_locked(const char *path, const mode_t mode) int git_futils_creat_locked(const char *path, const mode_t mode)
{ {
int fd = p_open(path, O_WRONLY | O_CREAT | O_TRUNC | int fd = p_open(path, O_WRONLY | O_CREAT | O_EXCL | O_BINARY | O_CLOEXEC,
O_EXCL | O_BINARY | O_CLOEXEC, mode); mode);
if (fd < 0) { if (fd < 0) {
int error = errno; int error = errno;