proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-08-08 09:17:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't overwrite existing objects

Browse Source 
It's redundant to do this (git doesn't) and Windows doesn't allow us
to overwrite a read-only file (which objects are).

Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
This commit is contained in:
Carlos Martín Nieto 2011-11-17 20:32:04 +01:00
parent 2cbca8b06c
commit 472d4d858b
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/odb_loose.c
View File

@ -670,6 +670,17 @@ static int loose_backend__stream_fwrite(git_oid *oid, git_odb_stream *_stream)
return git__rethrow(error, "Failed to write loose backend"); return git__rethrow(error, "Failed to write loose backend");
stream->finished = 1; stream->finished = 1;
/*
* Don't try to add an existing object to the repository. This
* is what git does and allows us to sidestep the fact that
* we're not allowed to overwrite a read-only file on Windows.
*/
if (git_futils_exists(final_path) == GIT_SUCCESS) {
git_filebuf_cleanup(&stream->fbuf);
return GIT_SUCCESS;
}
return git_filebuf_commit_at(&stream->fbuf, final_path, GIT_OBJECT_FILE_MODE); return git_filebuf_commit_at(&stream->fbuf, final_path, GIT_OBJECT_FILE_MODE);
} }