proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-05 22:35:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

stat: don't remove trailing '/' from root on win32

Browse Source 
`p_stat` calls `git_win32_path_from_utf8`, which canonicalizes the
path.  Do not further try to modify the path, else we trim the
trailing slash from a root directory and try to access `C:` instead
of `C:/`.
This commit is contained in:
Edward Thomson 2015-02-04 18:24:31 -05:00 committed by Edward Thomson
parent 2f4ee00039
commit 3c68bfcd08
2 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/win32/posix_w32.c
View File

@ -448,12 +448,8 @@ int p_stat(const char* path, struct stat* buf)
git_win32_path path_w; git_win32_path path_w;
int len; int len;
if ((len = git_win32_path_from_utf8(path_w, path)) < 0) if ((len = git_win32_path_from_utf8(path_w, path)) < 0 ||
return -1; lstat_w(path_w, buf, false) < 0)
git_win32__path_trim_end(path_w, len);
if (lstat_w(path_w, buf, false) < 0)
return -1; return -1;
/* The item is a symbolic link or mount point. No need to iterate /* The item is a symbolic link or mount point. No need to iterate

17
tests/core/stat.c
View File

@ -95,3 +95,20 @@ void test_core_stat__0(void)
cl_assert_error(ENOTDIR); cl_assert_error(ENOTDIR);
} }
void test_core_stat__root(void)
{
const char *sandbox = clar_sandbox_path();
git_buf root = GIT_BUF_INIT;
int root_len;
struct stat st;
root_len = git_path_root(sandbox);
cl_assert(root_len >= 0);
git_buf_set(&root, sandbox, root_len+1);
cl_must_pass(p_stat(root.ptr, &st));
cl_assert(S_ISDIR(st.st_mode));
git_buf_free(&root);
}