proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-07 10:31:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Set new multivar values using unmatcheable regexp.

Browse Source 
Seems that regexp in Mac OS X and Linux were behaving
differently: while in OS X the empty string didn't
match any value, in Linux it was matching all of them,
so the the second fetch refspec was overwritting the
first one, instead of creating a new one.

Using an unmatcheable regular expression solves the
problem (and seems to be portable).
This commit is contained in:
Daniel Rodríguez Troitiño 2013-10-31 23:42:04 +01:00
parent a71331ebc4
commit 376454d03d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/remote.c
View File

@ -387,8 +387,11 @@ static int update_config_refspec(const git_remote *remote, git_config *config, i
if (spec->push != push)
continue;
// "$^" is a unmatcheable regexp: it will not match anything at all, so
// all values will be considered new and we will not replace any
// present value.
if ((error = git_config_set_multivar(
config, cname, "", spec->string)) < 0) {
config, cname, "$^", spec->string)) < 0) {
goto cleanup;
}
}