From 358a15fd65cdc56ddc02b3ea261851f20c7ac618 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Fri, 30 Sep 2011 15:43:58 +0200 Subject: [PATCH] config: fix check for environment string expansion MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If ExpandEnvironmentStringsW is successful, it returns the amount of characters written, including the NUL terminator. Thanks to Emeric for reading the MSDN documentation correctly. Signed-off-by: Carlos Martín Nieto --- src/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/config.c b/src/config.c index c4f3807c2..54727c0f6 100644 --- a/src/config.c +++ b/src/config.c @@ -352,7 +352,7 @@ static int win32_find_system(char *system_config_path) return GIT_ENOMEM; ret = ExpandEnvironmentStringsW(query, apphome_utf16, size); - if (ret == 0 || ret >= size) + if (ret != size) return git__throw(GIT_ERROR, "Failed to expand environment strings"); if (_waccess(apphome_utf16, F_OK) < 0) {