From 34065968ed3c386b875ee050b8ed34d9968e2d7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Wed, 1 Jul 2015 17:49:07 +0200 Subject: [PATCH] submodule: completely remove reload_all The function was removed, but its declaration and changelog entry about its removal were forgotten. The comment in the test doesn't make any sense as the function doesn't exist anymore, so get rid of it as well. --- CHANGELOG.md | 3 +++ include/git2/submodule.h | 11 ----------- tests/submodule/nosubs.c | 2 -- 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e1406085d..418055ca3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -177,6 +177,9 @@ v0.22 + 1 * `git_submodule_save()` has been removed. The submodules are no longer configured via the objects. +* `git_submodule_reload_all()` has been removed as we no longer cache + submodules. + ### Breaking API changes * `git_smart_subtransport_cb` now has a `param` parameter. diff --git a/include/git2/submodule.h b/include/git2/submodule.h index cbafccd1b..689fe4b64 100644 --- a/include/git2/submodule.h +++ b/include/git2/submodule.h @@ -583,17 +583,6 @@ GIT_EXTERN(int) git_submodule_open( */ GIT_EXTERN(int) git_submodule_reload(git_submodule *submodule, int force); -/** - * Reread all submodule info. - * - * Call this to reload all cached submodule information for the repo. - * - * @param repo The repository to reload submodule data for - * @param force Force full reload even if the data doesn't seem out of date - * @return 0 on success, <0 on error - */ -GIT_EXTERN(int) git_submodule_reload_all(git_repository *repo, int force); - /** * Get the status for a submodule. * diff --git a/tests/submodule/nosubs.c b/tests/submodule/nosubs.c index 538825c1c..8a73dc11a 100644 --- a/tests/submodule/nosubs.c +++ b/tests/submodule/nosubs.c @@ -71,8 +71,6 @@ void test_submodule_nosubs__add_and_delete(void) git_submodule *sm; git_buf buf = GIT_BUF_INIT; - /* note lack of calls to git_submodule_reload_all - this *should* work */ - cl_git_fail(git_submodule_lookup(NULL, repo, "libgit2")); cl_git_fail(git_submodule_lookup(NULL, repo, "submodules/libgit2"));