proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-28 20:51:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add a test for custom header validation

Browse Source 
Also, *some* custom headers actually are valid.
This commit is contained in:
Matt Burke 2015-09-10 13:18:26 -04:00
parent 66d90e7098
commit 3245896bb7
2 changed files with 39 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/transports/smart.c
View File

@ -66,6 +66,10 @@ static int git_smart__set_callbacks(
return 0;
}
#define forbid_custom_header(disallowed_name) \
if (strncmp(disallowed_name, custom_header, name_len) == 0) \
return false
bool is_valid_custom_header(const char *custom_header)
{
const char *c;
@ -91,12 +95,14 @@ bool is_valid_custom_header(const char *custom_header)
return false;
// Disallow headers that we set
return git__strncmp("User-Agent", custom_header, name_len) == 0 &&
git__strncmp("Host", custom_header, name_len) == 0 &&
git__strncmp("Accept", custom_header, name_len) == 0 &&
git__strncmp("Content-Type", custom_header, name_len) == 0 &&
git__strncmp("Transfer-Encoding", custom_header, name_len) == 0 &&
git__strncmp("Content-Length", custom_header, name_len) == 0;
forbid_custom_header("User-Agent");
forbid_custom_header("Host");
forbid_custom_header("Accept");
forbid_custom_header("Content-Type");
forbid_custom_header("Transfer-Encoding");
forbid_custom_header("Content-Length");
return true;
}
const char *find_invalid_custom_header(const git_strarray *custom_headers)

27
tests/online/clone.c
View File

@ -213,6 +213,33 @@ void test_online_clone__custom_remote_callbacks(void)
cl_assert(callcount > 0);
}
void test_online_clone__custom_headers(void)
{
char *empty_header = "";
char *unnamed_header = "this is a header about nothing";
char *newlines = "X-Custom: almost OK\n";
char *conflict = "Accept: defined-by-git";
char *ok = "X-Custom: this should be ok";
g_options.fetch_opts.custom_headers.count = 1;
g_options.fetch_opts.custom_headers.strings = &empty_header;
cl_git_fail(git_clone(&g_repo, LIVE_REPO_URL, "./foo", &g_options));
g_options.fetch_opts.custom_headers.strings = &unnamed_header;
cl_git_fail(git_clone(&g_repo, LIVE_REPO_URL, "./foo", &g_options));
g_options.fetch_opts.custom_headers.strings = &newlines;
cl_git_fail(git_clone(&g_repo, LIVE_REPO_URL, "./foo", &g_options));
g_options.fetch_opts.custom_headers.strings = &conflict;
cl_git_fail(git_clone(&g_repo, LIVE_REPO_URL, "./foo", &g_options));
/* Finally, we got it right! */
g_options.fetch_opts.custom_headers.strings = &ok;
cl_git_pass(git_clone(&g_repo, LIVE_REPO_URL, "./foo", &g_options));
}
static int cred_failure_cb(
git_cred **cred,
const char *url,