proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-08-14 03:43:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a few leaks

Browse Source 
`git_diff_get_patch()` would unconditionally load the patch object and
then simply leak it if the user hadn't requested it. Short-circuit
loading the object if the user doesn't want it.

The rest of the plugs are simply calling the free functions of objects
allocated during the tests.
This commit is contained in:
Carlos Martín Nieto 2013-03-04 00:21:56 +01:00
parent dce5f26f4d
commit 323bb88514
4 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/diff_output.c
View File

@ -1509,6 +1509,10 @@ int git_diff_get_patch(
if (git_diff_delta__should_skip(ctxt.opts, delta))
return 0;
/* Don't load the patch if the user doesn't want it */
if (!patch_ptr)
return 0;
patch = diff_patch_alloc(&ctxt, delta);
if (!patch)
return -1;

2
tests-clar/diff/patch.c
View File

@ -239,6 +239,7 @@ void test_diff_patch__hunks_have_correct_line_numbers(void)
git_diff_patch_free(patch);
git_diff_list_free(diff);
git_tree_free(head);
git_config_free(cfg);
}
static void check_single_patch_stats(
@ -310,4 +311,5 @@ void test_diff_patch__line_counts_with_eofnl(void)
check_single_patch_stats(g_repo, 1, 1, 1);
git_buf_free(&content);
git_config_free(cfg);
}

1
tests-clar/diff/rename.c
View File

@ -274,6 +274,7 @@ void test_diff_rename__not_exact_match(void)
cl_assert_equal_i(2, exp.file_status[GIT_DELTA_MODIFIED]);
cl_assert_equal_i(2, exp.file_status[GIT_DELTA_ADDED]);
cl_assert_equal_i(2, exp.file_status[GIT_DELTA_DELETED]);
git_diff_list_free(diff);
/* git diff -M -C \
* 1c068dee5790ef1580cfc4cd670915b48d790084 \

2
tests-clar/stash/drop.c
View File

@ -169,4 +169,6 @@ void test_stash_drop__dropping_the_top_stash_updates_the_stash_reference(void)
cl_assert_equal_i(
true, git_oid_cmp(&oid, git_object_id(next_top_stash)) == 0);
git_object_free(next_top_stash);
}