From 616cd13757ece5becbba7b9ff556cf7ed5502431 Mon Sep 17 00:00:00 2001 From: Arthur Schreiber Date: Tue, 14 Jan 2014 21:08:09 +0100 Subject: [PATCH 1/2] Don't duplicate state that's only used when fetching. --- src/remote.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/remote.c b/src/remote.c index 6a4a707a4..089252668 100644 --- a/src/remote.c +++ b/src/remote.c @@ -272,7 +272,6 @@ int git_remote_dup(git_remote **dest, const git_remote *source) } remote->repo = source->repo; - remote->need_pack = source->need_pack; remote->download_tags = source->download_tags; remote->check_cert = source->check_cert; remote->update_fetchhead = source->update_fetchhead; From 99dcb2184a46140024de438a4a19ea5aada64be8 Mon Sep 17 00:00:00 2001 From: Arthur Schreiber Date: Tue, 14 Jan 2014 21:08:20 +0100 Subject: [PATCH 2/2] We don't need memset here. --- src/remote.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/remote.c b/src/remote.c index 089252668..622abbc8c 100644 --- a/src/remote.c +++ b/src/remote.c @@ -254,8 +254,6 @@ int git_remote_dup(git_remote **dest, const git_remote *source) git_remote *remote = git__calloc(1, sizeof(git_remote)); GITERR_CHECK_ALLOC(remote); - memset(remote, 0x0, sizeof(git_remote)); - if (source->name != NULL) { remote->name = git__strdup(source->name); GITERR_CHECK_ALLOC(remote->name);