proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-08 12:14:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remote: ensure the allocated remote is freed when an error occurs during its loading

Browse Source
This commit is contained in:
nulltoken 2012-05-07 10:04:50 +02:00
parent 8d89c8e972
commit 2fb9d6de95
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/remote.c
View File

@ -102,11 +102,15 @@ int git_remote_load(git_remote **out, git_repository *repo, const char *name)
remote->name = git__strdup(name); remote->name = git__strdup(name);
GITERR_CHECK_ALLOC(remote->name); GITERR_CHECK_ALLOC(remote->name);
if (git_vector_init(&remote->refs, 32, NULL) < 0) if (git_vector_init(&remote->refs, 32, NULL) < 0) {
return -1; error = -1;
goto cleanup;
}
if (git_buf_printf(&buf, "remote.%s.url", name) < 0) if (git_buf_printf(&buf, "remote.%s.url", name) < 0) {
return -1; error = -1;
goto cleanup;
}
if (git_config_get_string(config, git_buf_cstr(&buf), &val) < 0) { if (git_config_get_string(config, git_buf_cstr(&buf), &val) < 0) {
error = -1; error = -1;
@ -118,8 +122,10 @@ int git_remote_load(git_remote **out, git_repository *repo, const char *name)
GITERR_CHECK_ALLOC(remote->url); GITERR_CHECK_ALLOC(remote->url);
git_buf_clear(&buf); git_buf_clear(&buf);
if (git_buf_printf(&buf, "remote.%s.fetch", name) < 0) if (git_buf_printf(&buf, "remote.%s.fetch", name) < 0) {
return -1; error = -1;
goto cleanup;
}
error = parse_remote_refspec(config, &remote->fetch, git_buf_cstr(&buf)); error = parse_remote_refspec(config, &remote->fetch, git_buf_cstr(&buf));
if (error == GIT_ENOTFOUND) if (error == GIT_ENOTFOUND)
@ -131,8 +137,10 @@ int git_remote_load(git_remote **out, git_repository *repo, const char *name)
} }
git_buf_clear(&buf); git_buf_clear(&buf);
if (git_buf_printf(&buf, "remote.%s.push", name) < 0) if (git_buf_printf(&buf, "remote.%s.push", name) < 0) {
return -1; error = -1;
goto cleanup;
}
error = parse_remote_refspec(config, &remote->push, git_buf_cstr(&buf)); error = parse_remote_refspec(config, &remote->push, git_buf_cstr(&buf));
if (error == GIT_ENOTFOUND) if (error == GIT_ENOTFOUND)