Fix connection leak in http subtransport

This commit is contained in:
Philip Kelley 2012-11-06 09:36:04 -05:00
parent 091361f569
commit 2f7538ec00
2 changed files with 9 additions and 3 deletions

View File

@ -193,16 +193,19 @@ void gitno_consume_n(gitno_buffer *buf, size_t cons)
static int gitno_ssl_teardown(gitno_ssl *ssl)
{
int ret;
do {
ret = SSL_shutdown(ssl->ssl);
} while (ret == 0);
if (ret < 0)
return ssl_set_error(ssl, ret);
ret = ssl_set_error(ssl, ret);
else
ret = 0;
SSL_free(ssl->ssl);
SSL_CTX_free(ssl->ctx);
return 0;
return ret;
}
/* Match host names according to RFC 2818 rules */

View File

@ -606,6 +606,9 @@ static void http_free(git_smart_subtransport *smart_transport)
clear_parser_state(t);
if (t->socket.socket)
gitno_close(&t->socket);
if (t->cred) {
t->cred->free(t->cred);
t->cred = NULL;