From 2f683f00971239007e1d602ec1a71a1eb10f4f5e Mon Sep 17 00:00:00 2001 From: Philip Kelley Date: Fri, 9 Nov 2012 15:39:25 -0500 Subject: [PATCH] Fix uninitialized memory in winhttp subtransport on 64-bit --- src/transports/winhttp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/transports/winhttp.c b/src/transports/winhttp.c index 44617f389..df6cd87ec 100644 --- a/src/transports/winhttp.c +++ b/src/transports/winhttp.c @@ -278,6 +278,7 @@ static int winhttp_stream_read( { winhttp_stream *s = (winhttp_stream *)stream; winhttp_subtransport *t = OWNING_SUBTRANSPORT(s); + DWORD dw_bytes_read; replay: /* Connect if necessary */ @@ -376,12 +377,14 @@ replay: if (!WinHttpReadData(s->request, (LPVOID)buffer, buf_size, - (LPDWORD)bytes_read)) + &dw_bytes_read)) { giterr_set(GITERR_OS, "Failed to read data"); return -1; } + *bytes_read = dw_bytes_read; + return 0; }