From 2f512ff81e1705c0246416f2292b53540f88fd19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Fri, 5 Aug 2011 18:11:30 +0200 Subject: [PATCH] Use strcpy+strcat as memcpy was overlapping MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Carlos Martín Nieto --- src/transport_git.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/transport_git.c b/src/transport_git.c index 4a10f17cd..5f03a4b20 100644 --- a/src/transport_git.c +++ b/src/transport_git.c @@ -346,9 +346,10 @@ static int store_pack(char **out, gitno_buffer *buf, git_repository *repo) char path[GIT_PATH_MAX], suff[] = "/objects/pack/pack-received\0"; off_t off = 0; - memcpy(path, repo->path_repository, GIT_PATH_MAX - off); + strcpy(path, repo->path_repository); off += strlen(repo->path_repository); - memcpy(path + off, suff, GIT_PATH_MAX - off - STRLEN(suff)); + strcat(path, suff); + //memcpy(path + off, suff, GIT_PATH_MAX - off - STRLEN(suff) - 1); error = git_filebuf_open(&file, path, GIT_FILEBUF_TEMPORARY); if (error < GIT_SUCCESS)