proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-07 20:17:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Small fixes in pack_window_open

Browse Source 
Check if the window structure has actually been allocated before
trying to access it, and don't leak said structure if the map fails.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
This commit is contained in:
Carlos Martín Nieto 2011-07-05 15:09:17 +02:00
parent d830919a2c
commit 2ee318a7bc
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/odb_pack.c
View File

@ -480,6 +480,9 @@ static unsigned char *pack_window_open(
size_t len; size_t len;
win = git__calloc(1, sizeof(*win)); win = git__calloc(1, sizeof(*win));
if (win == NULL)
return NULL;
win->offset = (offset / window_align) * window_align; win->offset = (offset / window_align) * window_align;
len = (size_t)(p->pack_size - win->offset); len = (size_t)(p->pack_size - win->offset);
@ -492,8 +495,10 @@ static unsigned char *pack_window_open(
pack_window_close_lru(backend, p, p->pack_fd) == GIT_SUCCESS) {} pack_window_close_lru(backend, p, p->pack_fd) == GIT_SUCCESS) {}
if (git_futils_mmap_ro(&win->window_map, p->pack_fd, if (git_futils_mmap_ro(&win->window_map, p->pack_fd,
win->offset, len) < GIT_SUCCESS) win->offset, len) < GIT_SUCCESS) {
free(win);
return NULL; return NULL;
}
backend->mmap_calls++; backend->mmap_calls++;
backend->open_windows++; backend->open_windows++;