proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-05 20:33:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refs: copy the packed refs on iteration

Browse Source 
This lets us work without worrying about what's happening but work on a
snapshot.
This commit is contained in:
Carlos Martín Nieto 2014-06-02 17:44:51 +02:00
parent 4ee2543c5a
commit 2d945f82f6
1 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/refdb_fs.c
View File

@ -458,6 +458,7 @@ typedef struct {
git_pool pool; git_pool pool;
git_vector loose; git_vector loose;
git_sortedcache *cache;
size_t loose_pos; size_t loose_pos;
size_t packed_pos; size_t packed_pos;
} refdb_fs_iter; } refdb_fs_iter;
@ -468,6 +469,7 @@ static void refdb_fs_backend__iterator_free(git_reference_iterator *_iter)
git_vector_free(&iter->loose); git_vector_free(&iter->loose);
git_pool_clear(&iter->pool); git_pool_clear(&iter->pool);
git_sortedcache_free(iter->cache);
git__free(iter); git__free(iter);
} }
@ -539,10 +541,14 @@ static int refdb_fs_backend__iterator_next(
giterr_clear(); giterr_clear();
} }
git_sortedcache_rlock(backend->refcache); if (!iter->cache) {
if ((error = git_sortedcache_copy(&iter->cache, backend->refcache, 1, NULL, NULL)) < 0)
return error;
}
while (iter->packed_pos < git_sortedcache_entrycount(backend->refcache)) { error = GIT_ITEROVER;
ref = git_sortedcache_entry(backend->refcache, iter->packed_pos++); while (iter->packed_pos < git_sortedcache_entrycount(iter->cache)) {
ref = git_sortedcache_entry(iter->cache, iter->packed_pos++);
if (!ref) /* stop now if another thread deleted refs and we past end */ if (!ref) /* stop now if another thread deleted refs and we past end */
break; break;
@ -556,7 +562,6 @@ static int refdb_fs_backend__iterator_next(
break; break;
} }
git_sortedcache_runlock(backend->refcache);
return error; return error;
} }
@ -579,10 +584,14 @@ static int refdb_fs_backend__iterator_next_name(
giterr_clear(); giterr_clear();
} }
git_sortedcache_rlock(backend->refcache); if (!iter->cache) {
if ((error = git_sortedcache_copy(&iter->cache, backend->refcache, 1, NULL, NULL)) < 0)
return error;
}
while (iter->packed_pos < git_sortedcache_entrycount(backend->refcache)) { error = GIT_ITEROVER;
ref = git_sortedcache_entry(backend->refcache, iter->packed_pos++); while (iter->packed_pos < git_sortedcache_entrycount(iter->cache)) {
ref = git_sortedcache_entry(iter->cache, iter->packed_pos++);
if (!ref) /* stop now if another thread deleted refs and we past end */ if (!ref) /* stop now if another thread deleted refs and we past end */
break; break;
@ -596,7 +605,6 @@ static int refdb_fs_backend__iterator_next_name(
break; break;
} }
git_sortedcache_runlock(backend->refcache);
return error; return error;
} }