proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-05 20:33:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #1467 from carlosmn/commit-parse

Browse Source 
commit: correctly detect the start of the commit message
This commit is contained in:
Vicent Martí 2013-04-15 06:11:29 -07:00
commit 2d2260da41
2 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/commit.c
View File

@ -189,8 +189,8 @@ int git_commit__parse_buffer(git_commit *commit, const void *data, size_t len)
buffer = eoln; buffer = eoln;
} }
/* skip blank lines */ /* buffer is now at the end of the header, double-check and move forward into the message */
while (buffer < buffer_end - 1 && *buffer == '\n') if (buffer < buffer_end && *buffer == '\n')
buffer++; buffer++;
/* parse commit message */ /* parse commit message */

29
tests-clar/commit/parse.c
View File

@ -297,7 +297,7 @@ void test_commit_parse__entire_commit(void)
); );
if (!i) if (!i)
cl_assert_equal_s("\n", git_commit_message(commit)); cl_assert_equal_s("", git_commit_message(commit));
else else
cl_assert(git__prefixcmp( cl_assert(git__prefixcmp(
git_commit_message(commit), "a simple commit which works") == 0); git_commit_message(commit), "a simple commit which works") == 0);
@ -366,3 +366,30 @@ void test_commit_parse__details0(void) {
} }
} }
void test_commit_parse__leading_lf(void)
{
git_commit *commit;
const char *buffer =
"tree 1810dff58d8a660512d4832e740f692884338ccd\n\
parent e90810b8df3e80c413d903f631643c716887138d\n\
author Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
committer Vicent Marti <tanoku@gmail.com> 1273848544 +0200\n\
\n\
\n\
\n\
This commit has a few LF at the start of the commit message";
const char *message =
"\n\
\n\
This commit has a few LF at the start of the commit message";
commit = (git_commit*)git__malloc(sizeof(git_commit));
memset(commit, 0x0, sizeof(git_commit));
commit->object.repo = g_repo;
cl_git_pass(git_commit__parse_buffer(commit, buffer, strlen(buffer)));
cl_assert_equal_s(message, git_commit_message(commit));
git_commit__free(commit);
}