From 2af282d835662fce671cc1a6675b0b8292f05173 Mon Sep 17 00:00:00 2001
From: Christopher Bargren <cbargren@gmail.com>
Date: Wed, 8 Feb 2017 15:01:30 -0700
Subject: [PATCH] Addressing PR feedback

---
 src/remote.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/src/remote.c b/src/remote.c
index 1f5c58bd2..808ca78d5 100644
--- a/src/remote.c
+++ b/src/remote.c
@@ -770,21 +770,14 @@ int git_remote__get_http_proxy(git_remote *remote, bool use_ssl, char **proxy_ur
 		goto found;
 	}
 
-	/* HTTP_PROXY / HTTPS_PROXY environment variables */
-	error = git__getenv(&val, use_ssl ? "HTTPS_PROXY" : "HTTP_PROXY");
-
-	if (error < 0) {
-		if (error != GIT_ENOTFOUND) {
-			return error;
-		}
-
-		giterr_clear();
-		error = 0;
-	}
-
-	/* try lowercase environment variables */
+	/* http_proxy / https_proxy environment variables */
 	error = git__getenv(&val, use_ssl ? "https_proxy" : "http_proxy");
 
+	if (error == GIT_ENOTFOUND) {
+		/* try uppercase environment variables */
+		error = git__getenv(&val, use_ssl ? "HTTPS_PROXY" : "HTTP_PROXY");
+	}
+
 	if (error < 0) {
 		if (error == GIT_ENOTFOUND) {
 			giterr_clear();