proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-08-04 09:18:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

signature: extend trimming to more whitespace

Browse Source 
There are all sorts of misconfiguration in the wild. We already rely
on the signature constructor to trim SP. Extend the logic to use
`isspace` to decide whether a character should be trimmed.
This commit is contained in:
Carlos Martín Nieto 2013-06-11 10:48:00 +02:00
parent 3de768ca2f
commit 24ec69998d
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/signature.c
View File

@ -35,11 +35,11 @@ static bool contains_angle_brackets(const char *input)
static char *extract_trimmed(const char *ptr, size_t len) static char *extract_trimmed(const char *ptr, size_t len)
{ {
while (len && ptr[0] == ' ') { while (len && git__isspace(ptr[0])) {
ptr++; len--; ptr++; len--;
} }
while (len && ptr[len - 1] == ' ') { while (len && git__isspace(ptr[len - 1])) {
len--; len--;
} }

2
tests-clar/commit/signature.c
View File

@ -31,6 +31,8 @@ static void assert_name_and_email(
void test_commit_signature__leading_and_trailing_spaces_are_trimmed(void) void test_commit_signature__leading_and_trailing_spaces_are_trimmed(void)
{ {
assert_name_and_email("nulltoken", "emeric.fermas@gmail.com", " nulltoken ", " emeric.fermas@gmail.com "); assert_name_and_email("nulltoken", "emeric.fermas@gmail.com", " nulltoken ", " emeric.fermas@gmail.com ");
assert_name_and_email("nulltoken", "emeric.fermas@gmail.com", " nulltoken ", " emeric.fermas@gmail.com \n");
assert_name_and_email("nulltoken", "emeric.fermas@gmail.com", " \t nulltoken \n", " \n emeric.fermas@gmail.com \n");
} }
void test_commit_signature__angle_brackets_in_names_are_not_supported(void) void test_commit_signature__angle_brackets_in_names_are_not_supported(void)