Merge pull request #3578 from bubaflub/fix_small_memory_leak

Free allocated pointer to curl stream on error
This commit is contained in:
Carlos Martín Nieto 2016-02-05 15:19:24 -08:00
commit 240b6fed00

View File

@ -207,11 +207,14 @@ int git_curl_stream_new(git_stream **out, const char *host, const char *port)
handle = curl_easy_init(); handle = curl_easy_init();
if (handle == NULL) { if (handle == NULL) {
giterr_set(GITERR_NET, "failed to create curl handle"); giterr_set(GITERR_NET, "failed to create curl handle");
git__free(st);
return -1; return -1;
} }
if ((error = git__strtol32(&iport, port, NULL, 10)) < 0) if ((error = git__strtol32(&iport, port, NULL, 10)) < 0) {
git__free(st);
return error; return error;
}
curl_easy_setopt(handle, CURLOPT_URL, host); curl_easy_setopt(handle, CURLOPT_URL, host);
curl_easy_setopt(handle, CURLOPT_ERRORBUFFER, st->curl_error); curl_easy_setopt(handle, CURLOPT_ERRORBUFFER, st->curl_error);