proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-29 22:00:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remote: don't free the remote on delete

Browse Source 
This was a bad idea. Don't free except in the free function.
This commit is contained in:
Carlos Martín Nieto 2014-06-06 22:55:34 +02:00
parent d154456464
commit 231f350d91
3 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/git2/remote.h
View File

@ -618,8 +618,6 @@ GIT_EXTERN(int) git_remote_is_valid_name(const char *remote_name);
* All remote-tracking branches and configuration settings * All remote-tracking branches and configuration settings
* for the remote will be removed. * for the remote will be removed.
* *
* once deleted, the passed remote object will be freed and invalidated.
*
* @param remote A valid remote * @param remote A valid remote
* @return 0 on success, or an error code. * @return 0 on success, or an error code.
*/ */

2
src/remote.c
View File

@ -1921,8 +1921,6 @@ int git_remote_delete(git_remote *remote)
repo, git_remote_name(remote), NULL)) < 0) repo, git_remote_name(remote), NULL)) < 0)
return error; return error;
git_remote_free(remote);
return 0; return 0;
} }

2
tests/network/remote/delete.c
View File

@ -15,6 +15,7 @@ void test_network_remote_delete__initialize(void)
void test_network_remote_delete__cleanup(void) void test_network_remote_delete__cleanup(void)
{ {
git_remote_free(_remote);
cl_git_sandbox_cleanup(); cl_git_sandbox_cleanup();
} }
@ -27,7 +28,6 @@ void test_network_remote_delete__cannot_delete_an_anonymous_remote(void)
cl_git_fail(git_remote_delete(remote)); cl_git_fail(git_remote_delete(remote));
git_remote_free(remote); git_remote_free(remote);
git_remote_free(_remote);
} }
void test_network_remote_delete__remove_remote_tracking_branches(void) void test_network_remote_delete__remove_remote_tracking_branches(void)