From 21d73e7195a427b39c1c3742c85254e8384f5802 Mon Sep 17 00:00:00 2001 From: Vicent Marti Date: Tue, 22 Mar 2011 20:26:01 +0200 Subject: [PATCH] Always free the parents of a revwalk commit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks to Carlos Martín Nieto for spotting this. --- src/revwalk.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/revwalk.c b/src/revwalk.c index a9d4f8734..73bb060f5 100644 --- a/src/revwalk.c +++ b/src/revwalk.c @@ -482,11 +482,22 @@ int git_revwalk_new(git_revwalk **revwalk_out, git_repository *repo) void git_revwalk_free(git_revwalk *walk) { unsigned int i; + const void *_unused; + commit_object *commit; if (walk == NULL) return; git_revwalk_reset(walk); + + /* if the parent has more than PARENTS_PER_COMMIT parents, + * we had to allocate a separate array for those parents. + * make sure it's being free'd */ + GIT_HASHTABLE_FOREACH(walk->commits, _unused, commit, { + if (commit->out_degree > PARENTS_PER_COMMIT) + free(commit->parents); + }); + git_hashtable_free(walk->commits); git_pqueue_free(&walk->iterator_time);