proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-03 22:01:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

object validation: free some memleaks

Browse Source
This commit is contained in:
Edward Thomson 2017-05-01 21:34:21 +01:00
parent 34c1310624
commit 1dc89aab24
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/odb_loose.c
View File

@ -205,6 +205,11 @@ static int start_inflate(z_stream *s, git_buf *obj, void *out, size_t len)
return inflate(s, 0); return inflate(s, 0);
} }
static void abort_inflate(z_stream *s)
{
inflateEnd(s);
}
static int finish_inflate(z_stream *s) static int finish_inflate(z_stream *s)
{ {
int status = Z_OK; int status = Z_OK;
@ -367,6 +372,7 @@ static int inflate_disk_obj(git_rawobj *out, git_buf *obj)
(used = get_object_header(&hdr, head)) == 0 || (used = get_object_header(&hdr, head)) == 0 ||
!git_object_typeisloose(hdr.type)) !git_object_typeisloose(hdr.type))
{ {
abort_inflate(&zs);
giterr_set(GITERR_ODB, "failed to inflate disk object"); giterr_set(GITERR_ODB, "failed to inflate disk object");
return -1; return -1;
} }

1
tests/object/lookup.c
View File

@ -116,6 +116,7 @@ void test_object_lookup__lookup_object_with_wrong_hash_returns_error(void)
cl_git_pass(git_object_lookup(&object, g_repo, &oid, GIT_OBJ_COMMIT)); cl_git_pass(git_object_lookup(&object, g_repo, &oid, GIT_OBJ_COMMIT));
cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_HASH_VERIFICATION, 1)); cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_HASH_VERIFICATION, 1));
git_object_free(object);
git_buf_free(&oldpath); git_buf_free(&oldpath);
git_buf_free(&newpath); git_buf_free(&newpath);
} }