From 151b321898a4b24bfa25f0c4a6bacf6565e0cdb4 Mon Sep 17 00:00:00 2001
From: Ben Straub <bs@github.com>
Date: Thu, 31 Oct 2013 13:16:04 -0700
Subject: [PATCH] Prevent segfault with a badly-formed URL

---
 src/netops.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/netops.c b/src/netops.c
index 7a61ef820..5f0db24ef 100644
--- a/src/netops.c
+++ b/src/netops.c
@@ -679,9 +679,10 @@ int gitno_extract_url_parts(
 	slash = strchr(url, '/');
 	at = strchr(url, '@');
 
-	if (slash == NULL) {
-		giterr_set(GITERR_NET, "Malformed URL: missing /");
-		return -1;
+	if (!slash ||
+	    (colon && slash < colon)) {
+		giterr_set(GITERR_NET, "Malformed URL");
+		return GIT_EINVALIDSPEC;
 	}
 
 	start = url;