proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-12-26 09:16:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

netops: error out on url without a path

Browse Source 
In order to connect to a remote server, we need to provide a path to the
repository we're interested in. Consider the lack of path in the url an
error.
This commit is contained in:
Carlos Martín Nieto 2014-07-03 02:34:32 +02:00
parent 28f087c864
commit 1380e7c6b1
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/netops.c
View File

@ -717,6 +717,9 @@ int gitno_extract_url_parts(
if (u.field_set & (1 << UF_PATH)) {
*path = git__substrdup(_path, u.field_data[UF_PATH].len);
GITERR_CHECK_ALLOC(*path);
} else {
giterr_set(GITERR_NET, "invalid url, missing path");
return GIT_EINVALIDSPEC;
}
if (u.field_set & (1 << UF_USERINFO)) {

18
tests/network/urlparse.c
View File

@ -33,6 +33,24 @@ void test_network_urlparse__trivial(void)
cl_assert_equal_p(pass, NULL);
}
void test_network_urlparse__root(void)
{
cl_git_pass(gitno_extract_url_parts(&host, &port, &path, &user, &pass,
"http://example.com/", "8080"));
cl_assert_equal_s(host, "example.com");
cl_assert_equal_s(port, "8080");
cl_assert_equal_s(path, "/");
cl_assert_equal_p(user, NULL);
cl_assert_equal_p(pass, NULL);
}
void test_network_urlparse__just_hostname(void)
{
cl_git_fail_with(GIT_EINVALIDSPEC,
gitno_extract_url_parts(&host, &port, &path, &user, &pass,
"http://example.com", "8080"));
}
void test_network_urlparse__encoded_password(void)
{
cl_git_pass(gitno_extract_url_parts(&host, &port, &path, &user, &pass,