proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-29 18:38:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

git_futils_readbuffer: don't compute sha-1

Browse Source 
Don't compute the sha-1 in `git_futils_readbuffer_updated` unless the
checksum was requested.  This means that `git_futils_readbuffer` will
not calculate the checksum unnecessarily.
This commit is contained in:
Edward Thomson 2017-03-09 12:26:23 +00:00
parent b31b236004
commit 11c8e756ac
1 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/fileops.c
View File

@ -196,28 +196,29 @@ int git_futils_readbuffer_updated(
p_close(fd); p_close(fd);
if ((error = git_hash_buf(&checksum_new, buf.ptr, buf.size)) < 0) { if (checksum) {
git_buf_free(&buf); if ((error = git_hash_buf(&checksum_new, buf.ptr, buf.size)) < 0) {
return error; git_buf_free(&buf);
} return error;
}
/* /*
* If we were given a checksum, we only want to use it if it's different * If we were given a checksum, we only want to use it if it's different
*/ */
if (checksum && !git_oid__cmp(checksum, &checksum_new)) { if (!git_oid__cmp(checksum, &checksum_new)) {
git_buf_free(&buf); git_buf_free(&buf);
if (updated) if (updated)
*updated = 0; *updated = 0;
return 0; return 0;
}
git_oid_cpy(checksum, &checksum_new);
} }
/* /*
* If we're here, the file did change, or the user didn't have an old version * If we're here, the file did change, or the user didn't have an old version
*/ */
if (checksum)
git_oid_cpy(checksum, &checksum_new);
if (updated != NULL) if (updated != NULL)
*updated = 1; *updated = 1;