proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-29 15:10:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tree cache: loosen negative entry count check

Browse Source 
While C Git has been writing entry count -1 (ie. never other negative
numbers) as invalid since day 1, it accepts all negative entry counts
as invalid. JGit follows the same rule. libgit2 should also follow, or
the index that works with C Git or JGit may someday be rejected by
libgit2.

Other reimplementations like dulwich and grit have not bothered with
parsing or writing tree cache.
This commit is contained in:
Nguyễn Thái Ngọc Duy 2012-12-12 19:23:05 +07:00
parent 8d13035e0d
commit 08f3d6caf4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tree-cache.c
View File

@ -104,7 +104,7 @@ static int read_tree_internal(git_tree_cache **out,
tree->name[name_len] = '\0'; tree->name[name_len] = '\0';
/* Blank-terminated ASCII decimal number of entries in this tree */ /* Blank-terminated ASCII decimal number of entries in this tree */
if (git__strtol32(&count, buffer, &buffer, 10) < 0 || count < -1) if (git__strtol32(&count, buffer, &buffer, 10) < 0)
goto corrupted; goto corrupted;
tree->entries = count; tree->entries = count;