diff --git a/src/revparse.c b/src/revparse.c index b895b9067..dab74d66a 100644 --- a/src/revparse.c +++ b/src/revparse.c @@ -29,9 +29,10 @@ static void set_invalid_syntax_err(const char *spec) static int revparse_lookup_fully_qualifed_ref(git_object **out, git_repository *repo, const char*spec) { git_oid resolved; + int error; - if (git_reference_name_to_oid(&resolved, repo, spec) < 0) - return GIT_ERROR; + if ((error = git_reference_name_to_oid(&resolved, repo, spec)) < 0) + return error; return git_object_lookup(out, repo, &resolved, GIT_OBJ_ANY); } diff --git a/tests-clar/refs/revparse.c b/tests-clar/refs/revparse.c index 7c5c917de..68479962d 100644 --- a/tests-clar/refs/revparse.c +++ b/tests-clar/refs/revparse.c @@ -128,6 +128,8 @@ void test_refs_revparse__reflog(void) cl_git_fail(git_revparse_single(&g_obj, g_repo, "@{-0}")); cl_git_fail(git_revparse_single(&g_obj, g_repo, "@{1000}")); + cl_assert_equal_i(GIT_ENOTFOUND, git_revparse_single(&g_obj, g_repo, "nope@{0}")); + test_object("@{-2}", "a65fedf39aefe402d3bb6e24df4d4f5fe4547750"); test_object("@{-1}", "a4a7dce85cf63874e984719f4fdd239f5145052f"); test_object("master@{0}", "a65fedf39aefe402d3bb6e24df4d4f5fe4547750");