proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-08-12 12:00:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed memory leaks in test suite

Browse Source 
Created commit objects in t0401-parse weren't being freed properly.
Updated the API documentation to note that commit objects are owned
by the revision pool and should not be freed manually.

The parents list of each commit was being freed twice after each test.

Signed-off-by: Vicent Marti <tanoku@gmail.com>
This commit is contained in:
Vicent Marti 2010-06-09 14:54:22 +02:00
parent 58b0cbea74
commit 088a731f00
4 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/commit.c
View File

@ -204,7 +204,7 @@ int git_commit__parse_buffer(git_commit *commit, void *data, size_t len)
if (commit->uninteresting) if (commit->uninteresting)
parent->uninteresting = 1; parent->uninteresting = 1;
if (git_commit_list_push_back(&commit->parents, parent)) if (git_commit_list_push_back(&commit->parents, parent) < 0)
return GIT_ENOMEM; return GIT_ENOMEM;
} }

6
src/git/commit.h
View File

@ -18,6 +18,9 @@ typedef struct git_commit git_commit;
/** /**
* Locate a reference to a commit without loading it. * Locate a reference to a commit without loading it.
* The generated commit object is owned by the revision
* pool and shall not be freed by the user.
*
* @param pool the pool to use when locating the commit. * @param pool the pool to use when locating the commit.
* @param id identity of the commit to locate. If the object is * @param id identity of the commit to locate. If the object is
* an annotated tag it will be peeled back to the commit. * an annotated tag it will be peeled back to the commit.
@ -28,6 +31,9 @@ GIT_EXTERN(git_commit *) git_commit_lookup(git_revpool *pool, const git_oid *id)
/** /**
* Locate a reference to a commit, and try to load and parse it it from * Locate a reference to a commit, and try to load and parse it it from
* the commit cache or the object database. * the commit cache or the object database.
* The generated commit object is owned by the revision
* pool and shall not be freed by the user.
*
* @param pool the pool to use when parsing/caching the commit. * @param pool the pool to use when parsing/caching the commit.
* @param id identity of the commit to locate. If the object is * @param id identity of the commit to locate. If the object is
* an annotated tag it will be peeled back to the commit. * an annotated tag it will be peeled back to the commit.

1
src/revwalk.c
View File

@ -54,6 +54,7 @@ void gitrp_free(git_revpool *walk)
git_revpool_tableit_init(walk->commits, &it); git_revpool_tableit_init(walk->commits, &it);
while ((commit = (git_commit *)git_revpool_tableit_next(&it)) != NULL) { while ((commit = (git_commit *)git_revpool_tableit_next(&it)) != NULL) {
git_commit_list_clear(&commit->parents, 0);
free(commit); free(commit);
} }

4
tests/t0401-parse.c
View File

@ -151,6 +151,8 @@ BEGIN_TEST(parse_buffer_test)
test_commits_broken[i], test_commits_broken[i],
strlen(test_commits_broken[i])) strlen(test_commits_broken[i]))
); );
git_commit_list_clear(&commit.parents, 0);
} }
for (i = 0; i < working_commit_count; ++i) { for (i = 0; i < working_commit_count; ++i) {
@ -163,6 +165,8 @@ BEGIN_TEST(parse_buffer_test)
test_commits_working[i], test_commits_working[i],
strlen(test_commits_working[i])) strlen(test_commits_working[i]))
); );
git_commit_list_clear(&commit.parents, 0);
} }
gitrp_free(pool); gitrp_free(pool);