proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-08-12 08:34:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

remote: delete git_remote_supported_url()

Browse Source 
This function does not in fact tell us anything, as almost anything with
a colon in it is a valid rsync-style SSH path; it can not tell us that
we do not support ftp or afp or similar as those are still valid SSH
paths and we do support that.
This commit is contained in:
Carlos Martín Nieto 2014-10-24 12:19:13 +02:00
parent 4bb6ffb6bb
commit 0862f617da
4 changed files with 3 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -46,6 +46,9 @@ v0.21 + 1
* git_remote_delete() now accepts the repository and the remote's name
instead of a loaded remote.
* git_remote_supported_url() has been removed as it has become
essentially useless with rsync-style ssh paths.
* The git_clone_options struct no longer provides the ignore_cert_errors or
remote_name members for remote customization.

13
include/git2/remote.h
View File

@ -389,19 +389,6 @@ GIT_EXTERN(int) git_remote_fetch(
const git_signature *signature,
const char *reflog_message);
/**
*
* Return whether the library supports a particular URL scheme
*
* Both the built-in and externally-registered transport lists are
* searched for a transport which supports the scheme of the given
* URL.
*
* @param url the url to check
* @return 1 if the url is supported, 0 otherwise
*/
GIT_EXTERN(int) git_remote_supported_url(const char* url);
/**
* Get a list of the configured remotes for a repo
*

9
src/transport.c
View File

@ -212,15 +212,6 @@ done:
return error;
}
int git_remote_supported_url(const char* url)
{
git_transport_cb fn;
void *param;
/* The only error we expect is ENOTFOUND */
return !transport_find_fn(&fn, url, &param);
}
int git_transport_init(git_transport *opts, unsigned int version)
{
GIT_INIT_STRUCTURE_FROM_TEMPLATE(

20
tests/network/remote/remotes.c
View File

@ -91,26 +91,6 @@ void test_network_remote_remotes__error_when_no_push_available(void)
git_remote_free(r);
}
void test_network_remote_remotes__supported_urls(void)
{
int ssh_supported = 0, https_supported = 0;
#ifdef GIT_SSH
ssh_supported = 1;
#endif
#if defined(GIT_SSL) || defined(GIT_WINHTTP)
https_supported = 1;
#endif
cl_assert(git_remote_supported_url("git://github.com/libgit2/libgit2"));
cl_assert(git_remote_supported_url("http://github.com/libgit2/libgit2"));
cl_assert_equal_i(ssh_supported, git_remote_supported_url("git@github.com:libgit2/libgit2.git"));
cl_assert_equal_i(ssh_supported, git_remote_supported_url("ssh://git@github.com/libgit2/libgit2.git"));
cl_assert_equal_i(https_supported, git_remote_supported_url("https://github.com/libgit2/libgit2.git"));
}
void test_network_remote_remotes__refspec_parsing(void)
{
cl_assert_equal_s(git_refspec_src(_refspec), "refs/heads/*");