proxmox-mirrors/libgit2
1
0
Fork 0
mirror of https://git.proxmox.com/git/libgit2 synced 2025-05-29 22:25:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add a few malloc checks

Browse Source 
Add checks to see if malloc failed when allocating the tag members and
signature members.

Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
This commit is contained in:
Carlos Martín Nieto 2011-04-07 14:38:03 +02:00 committed by Vicent Marti
parent 4a34b3a9ff
commit 076141a137
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/signature.c
View File

@ -140,6 +140,9 @@ int git_signature__parse(git_signature *sig, const char **buffer_out,
name_length = name_end - buffer - 1; name_length = name_end - buffer - 1;
sig->name = git__malloc(name_length + 1); sig->name = git__malloc(name_length + 1);
if (sig->name == NULL)
return GIT_ENOMEM;
memcpy(sig->name, buffer, name_length); memcpy(sig->name, buffer, name_length);
sig->name[name_length] = 0; sig->name[name_length] = 0;
buffer = name_end + 1; buffer = name_end + 1;
@ -153,6 +156,9 @@ int git_signature__parse(git_signature *sig, const char **buffer_out,
email_length = email_end - buffer; email_length = email_end - buffer;
sig->email = git__malloc(email_length + 1); sig->email = git__malloc(email_length + 1);
if (sig->name == NULL)
return GIT_ENOMEM;
memcpy(sig->email, buffer, email_length); memcpy(sig->email, buffer, email_length);
sig->email[email_length] = 0; sig->email[email_length] = 0;
buffer = email_end + 1; buffer = email_end + 1;

8
src/tag.c
View File

@ -131,12 +131,17 @@ static int parse_tag_buffer(git_tag *tag, const char *buffer, const char *buffer
text_len = search - buffer; text_len = search - buffer;
tag->tag_name = git__malloc(text_len + 1); tag->tag_name = git__malloc(text_len + 1);
if (tag->tag_name == NULL)
return GIT_ENOMEM;
memcpy(tag->tag_name, buffer, text_len); memcpy(tag->tag_name, buffer, text_len);
tag->tag_name[text_len] = '\0'; tag->tag_name[text_len] = '\0';
buffer = search + 1; buffer = search + 1;
tag->tagger = git__malloc(sizeof(git_signature)); tag->tagger = git__malloc(sizeof(git_signature));
if (tag->tagger == NULL)
return GIT_ENOMEM;
if ((error = git_signature__parse(tag->tagger, &buffer, buffer_end, "tagger ")) != 0) { if ((error = git_signature__parse(tag->tagger, &buffer, buffer_end, "tagger ")) != 0) {
free(tag->tag_name); free(tag->tag_name);
@ -147,6 +152,9 @@ static int parse_tag_buffer(git_tag *tag, const char *buffer, const char *buffer
text_len = buffer_end - ++buffer; text_len = buffer_end - ++buffer;
tag->message = git__malloc(text_len + 1); tag->message = git__malloc(text_len + 1);
if (tag->message == NULL)
return GIT_ENOMEM;
memcpy(tag->message, buffer, text_len); memcpy(tag->message, buffer, text_len);
tag->message[text_len] = '\0'; tag->message[text_len] = '\0';