proxmox-mirrors/grub2
1
0
Fork 0
mirror of https://git.proxmox.com/git/grub2 synced 2025-08-07 23:34:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

sh -ec is only appropriate for /etc/default/grub, not /etc/grub.d/*

Browse Source
This commit is contained in:
Colin Watson 2011-06-29 12:55:31 +01:00
parent a5cee8c7d7
commit f4f0a8e903
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
debian/apport/source_grub2.py vendored
View File

@ -14,6 +14,15 @@ import subprocess
import re import re
def check_shell_syntax(path): def check_shell_syntax(path):
''' Check the syntax of a shell script '''
try:
subprocess.check_call(['/bin/sh', '-n', path],
stderr=open(os.devnull,'w'))
except subprocess.CalledProcessError:
return False
return True
def check_shell_syntax_harder(path):
''' Check the syntax of a shell script ''' ''' Check the syntax of a shell script '''
try: try:
# sh -n is tempting, but not good enough. Consider this case: # sh -n is tempting, but not good enough. Consider this case:
@ -57,7 +66,7 @@ def add_info(report):
attach_file_if_exists(report, '/boot/grub/device.map', 'DeviceMap') attach_file_if_exists(report, '/boot/grub/device.map', 'DeviceMap')
invalid_grub_script = [] invalid_grub_script = []
if not check_shell_syntax('/etc/default/grub'): if not check_shell_syntax_harder('/etc/default/grub'):
invalid_grub_script.append('/etc/default/grub') invalid_grub_script.append('/etc/default/grub')
# Check scripts in /etc/grub.d since some users directly change # Check scripts in /etc/grub.d since some users directly change