proxmox-mirrors/grub2
1
0
Fork 0
mirror of https://git.proxmox.com/git/grub2 synced 2025-08-06 10:32:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

kern/partition: Check for NULL before dereferencing input string

Browse Source 
There is the possibility that the value of str comes from an external
source and continuing to use it before ever checking its validity is
wrong. So, needs fixing.

Additionally, drop unneeded part initialization.

Fixes: CID 292444

Signed-off-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Darren Kenny 2020-10-23 09:49:59 +00:00 committed by Daniel Kiper
parent 2777cf4466
commit bc9c468a2c
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
grub-core/kern/partition.c
View File

@ -109,11 +109,14 @@ grub_partition_map_probe (const grub_partition_map_t partmap,
grub_partition_t
grub_partition_probe (struct grub_disk *disk, const char *str)
{
grub_partition_t part = 0;
grub_partition_t part;
grub_partition_t curpart = 0;
grub_partition_t tail;
const char *ptr;
if (str == NULL)
return 0;
part = tail = disk->partition;
for (ptr = str; *ptr;)