From 7da1d0dde1e4a7d37872ece8ef1dd2a68f84b4cc Mon Sep 17 00:00:00 2001 From: Dimitri John Ledkov Date: Thu, 29 Apr 2021 12:34:34 +0100 Subject: [PATCH] osdep/unix/exec: Avoid atexit() handlers when child execvp() fails The functions grub_util_exec_pipe() and grub_util_exec_pipe_stderr() currently call execvp(). If the call fails for any reason, the child currently calls exit(127). This in turn executes the parents atexit() handlers from the forked child, and then the same handlers are called again from parent. This is usually not desired, and can lead to deadlocks, and undesired behavior. So, change the exit() calls to _exit() calls to avoid calling atexit() handlers from child. Fixes: e75cf4a58 (unix exec: avoid atexit handlers when child exits) Signed-off-by: Dimitri John Ledkov Reviewed-by: Daniel Kiper --- grub-core/osdep/unix/exec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/osdep/unix/exec.c b/grub-core/osdep/unix/exec.c index db3259f65..e8db9202f 100644 --- a/grub-core/osdep/unix/exec.c +++ b/grub-core/osdep/unix/exec.c @@ -188,7 +188,7 @@ grub_util_exec_pipe (const char *const *argv, int *fd) close (pipe_fd[1]); execvp ((char *) argv[0], (char **) argv); - exit (127); + _exit (127); } else { @@ -234,7 +234,7 @@ grub_util_exec_pipe_stderr (const char *const *argv, int *fd) close (pipe_fd[1]); execvp ((char *) argv[0], (char **) argv); - exit (127); + _exit (127); } else {