proxmox-mirrors/grub2
1
0
Fork 0
mirror of https://git.proxmox.com/git/grub2 synced 2025-07-21 17:50:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

script/execute: Don't crash on a "for" loop with no items

Browse Source 
The following crashes the parser:

  for x in; do
  0
  done

This is because grub_script_arglist_to_argv() doesn't consider the
possibility that arglist is NULL. Catch that explicitly.

This avoids a NULL pointer dereference.

Signed-off-by: Daniel Axtens <dja@axtens.net>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
This commit is contained in:
Daniel Axtens 2021-01-22 16:18:26 +11:00 committed by Daniel Kiper
parent 2a330dba93
commit 0a05f88e2b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
grub-core/script/execute.c
View File

@ -624,6 +624,9 @@ grub_script_arglist_to_argv (struct grub_script_arglist *arglist,
struct grub_script_arg *arg = 0; struct grub_script_arg *arg = 0;
struct grub_script_argv result = { 0, 0, 0 }; struct grub_script_argv result = { 0, 0, 0 };
if (arglist == NULL)
return 1;
for (; arglist && arglist->arg; arglist = arglist->next) for (; arglist && arglist->arg; arglist = arglist->next)
{ {
if (grub_script_argv_next (&result)) if (grub_script_argv_next (&result))