fwupd/plugins/redfish/fu-redfish-multipart-device.c
Richard Hughes 40cd18fa97 Allow using a per-device global percentage completion
It's actually quite hard to build a front-end for fwupd at the moment
as you're never sure when the progress bar is going to zip back to 0%
and start all over again. Some plugins go 0..100% for write, others
go 0..100% for erase, then again for write, then *again* for verify.

By creating a helper object we can easily split up the progress of the
specific task, e.g. write_firmware().

We can encode at the plugin level "the erase takes 50% of the time, the
write takes 40% and the read takes 10%". This means we can have a
progressbar which goes up just once at a consistent speed.
2021-09-13 14:28:15 +01:00

157 lines
5.2 KiB
C

/*
* Copyright (C) 2021 Richard Hughes <richard@hughsie.com>
*
* SPDX-License-Identifier: LGPL-2.1+
*/
#include "config.h"
#include <curl/curl.h>
#include "fu-redfish-multipart-device.h"
#include "fu-redfish-request.h"
struct _FuRedfishMultipartDevice {
FuRedfishDevice parent_instance;
};
G_DEFINE_TYPE(FuRedfishMultipartDevice, fu_redfish_multipart_device, FU_TYPE_REDFISH_DEVICE)
G_DEFINE_AUTOPTR_CLEANUP_FUNC(curl_mime, curl_mime_free)
static GString *
fu_redfish_multipart_device_get_parameters(FuRedfishMultipartDevice *self)
{
g_autoptr(GString) str = g_string_new(NULL);
g_autoptr(JsonBuilder) builder = json_builder_new();
g_autoptr(JsonGenerator) json_generator = json_generator_new();
g_autoptr(JsonNode) json_root = NULL;
/* create header */
json_builder_begin_object(builder);
json_builder_set_member_name(builder, "Targets");
json_builder_begin_array(builder);
if (!fu_device_has_private_flag(FU_DEVICE(self), FU_REDFISH_DEVICE_FLAG_WILDCARD_TARGETS)) {
const gchar *logical_id = fu_device_get_logical_id(FU_DEVICE(self));
json_builder_add_string_value(builder, logical_id);
}
json_builder_end_array(builder);
json_builder_set_member_name(builder, "@Redfish.OperationApplyTime");
json_builder_add_string_value(builder, "Immediate");
json_builder_end_object(builder);
/* export as a string */
json_root = json_builder_get_root(builder);
json_generator_set_pretty(json_generator, TRUE);
json_generator_set_root(json_generator, json_root);
json_generator_to_gstring(json_generator, str);
return g_steal_pointer(&str);
}
static gboolean
fu_redfish_multipart_device_write_firmware(FuDevice *device,
FuFirmware *firmware,
FuProgress *progress,
FwupdInstallFlags flags,
GError **error)
{
FuRedfishMultipartDevice *self = FU_REDFISH_MULTIPART_DEVICE(device);
FuRedfishBackend *backend = fu_redfish_device_get_backend(FU_REDFISH_DEVICE(self));
CURL *curl;
JsonObject *json_obj;
curl_mimepart *part;
const gchar *location;
g_autofree gchar *filename = NULL;
g_autoptr(curl_mime) mime = NULL;
g_autoptr(FuRedfishRequest) request = NULL;
g_autoptr(GBytes) fw = NULL;
g_autoptr(GString) params = NULL;
/* get default image */
fw = fu_firmware_get_bytes(firmware, error);
if (fw == NULL)
return FALSE;
/* Get the update version */
filename = g_strdup_printf("%s.bin", fu_device_get_name(FU_DEVICE(self)));
/* create the multipart request */
request = fu_redfish_backend_request_new(backend);
curl = fu_redfish_request_get_curl(request);
mime = curl_mime_init(curl);
curl_easy_setopt(curl, CURLOPT_MIMEPOST, mime);
params = fu_redfish_multipart_device_get_parameters(self);
part = curl_mime_addpart(mime);
curl_mime_name(part, "UpdateParameters");
curl_mime_type(part, "application/json");
curl_mime_data(part, params->str, CURL_ZERO_TERMINATED);
if (g_getenv("FWUPD_REDFISH_VERBOSE") != NULL)
g_debug("request: %s", params->str);
part = curl_mime_addpart(mime);
curl_mime_name(part, "UpdateFile");
curl_mime_type(part, "application/octet-stream");
curl_mime_filedata(part, filename);
curl_mime_data(part, g_bytes_get_data(fw, NULL), g_bytes_get_size(fw));
fu_progress_set_status(progress, FWUPD_STATUS_DEVICE_WRITE);
if (!fu_redfish_request_perform(request,
fu_redfish_backend_get_push_uri_path(backend),
FU_REDFISH_REQUEST_PERFORM_FLAG_LOAD_JSON,
error))
return FALSE;
if (fu_redfish_request_get_status_code(request) != 202) {
g_set_error(error,
FWUPD_ERROR,
FWUPD_ERROR_INVALID_FILE,
"failed to upload %s: %li",
filename,
fu_redfish_request_get_status_code(request));
return FALSE;
}
/* prefer the header, otherwise fall back to the response */
json_obj = fu_redfish_request_get_json_object(request);
if (json_object_has_member(json_obj, "TaskMonitor")) {
const gchar *tmp = json_object_get_string_member(json_obj, "TaskMonitor");
g_debug("task manager for cleanup is %s", tmp);
}
/* poll the task for progress */
if (!json_object_has_member(json_obj, "@odata.id")) {
g_set_error(error,
FWUPD_ERROR,
FWUPD_ERROR_INVALID_FILE,
"no task returned for %s",
fu_redfish_backend_get_push_uri_path(backend));
return FALSE;
}
location = json_object_get_string_member(json_obj, "@odata.id");
return fu_redfish_device_poll_task(FU_REDFISH_DEVICE(self), location, progress, error);
}
static void
fu_redfish_multipart_device_set_progress(FuDevice *self, FuProgress *progress)
{
fu_progress_set_id(progress, G_STRLOC);
fu_progress_add_step(progress, FWUPD_STATUS_DEVICE_RESTART, 0); /* detach */
fu_progress_add_step(progress, FWUPD_STATUS_DEVICE_WRITE, 100); /* write */
fu_progress_add_step(progress, FWUPD_STATUS_DEVICE_RESTART, 0); /* attach */
fu_progress_add_step(progress, FWUPD_STATUS_DEVICE_BUSY, 0); /* reload */
}
static void
fu_redfish_multipart_device_init(FuRedfishMultipartDevice *self)
{
fu_device_set_summary(FU_DEVICE(self), "Redfish multipart device");
}
static void
fu_redfish_multipart_device_class_init(FuRedfishMultipartDeviceClass *klass)
{
FuDeviceClass *klass_device = FU_DEVICE_CLASS(klass);
klass_device->write_firmware = fu_redfish_multipart_device_write_firmware;
klass_device->set_progress = fu_redfish_multipart_device_set_progress;
}